Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #37772 - inlineHelp Toggle Button control #37819

Merged
merged 4 commits into from
May 18, 2022
Merged

FIX #37772 - inlineHelp Toggle Button control #37819

merged 4 commits into from
May 18, 2022

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented May 17, 2022 •
edited
Loading

Pull Request for Issue #37772 .

Summary of Changes

  • Add inlineHelp option to formField
  • Control if inlineHelp toggle button is enabled for the current form
  • Add 'hide-aware-inline-help d-none' if enabled, as default description class
  • You can know add an xml form field attribute "inlinehelp" to use or not the toggling of description field by field (values boolean true/false). Eg. inlinehelp="false" applied on one field, will keep always the description shown even if click on description toggle.

UPDATE: see PR #37849 removing the inlinehelp attribute availability for form field xml element.

Testing Instructions

  • Check if descriptions are hidden by default in com_config and com_content options.
  • Check if descriptions are shown by default everywhere else (where toggle button is not integrated) : component options, item edition, plugins manager... and in third-party extensions not integrating the toggle button.
  • Toggle button works as expected in com_config and com_content

Actual result BEFORE applying this Pull Request

  • Description is hidden on all places where inlinehelp toggle button is not integrated. Almost everywhere in 4.1.3.

Expected result AFTER applying this Pull Request

  • Description is shown if no inlinehelp toggle button.

Documentation Changes Required

inline help global documentation, and form field attribute inlinehelp.

@cyrezdev cyrezdev mentioned this pull request May 17, 2022
Closed
@richard67 richard67 mentioned this pull request May 17, 2022
Merged
@bembelimen bembelimen added this to the Joomla 4.1.4 milestone May 17, 2022
@Valc
Copy link

Valc commented May 18, 2022 •
edited
Loading

Hi :)
After test your patch all is working as you explain: the views with 'Options' button that have not an "inlinehelp" are displaying the desc text.

At com_content pressing the "inlinehelp" is also working.

But at "com_config" >> "Options" with an "inlinehelp" button is failing: pressing it has no effect.

fail

I know Github has a "tested with success or not" button, but each time a search it i can't found it easy... can you point me to the button, please?

For me is not working at all as is expected due at com_config is failing toggle it.

If i understand right this patch is not focused to solve the issue about editing modules than also lost the desc text: this one is also an

Check if descriptions are shown by default everywhere else (where toggle button is not integrated) : component options, item edition, plugins manager... and in third-party extensions not integrating the toggle button.

EDITED

So, at modules item edition is not working, and at my third-party extensions site module the same.

Forgot it! at modules edition is also working like a charm! XD
working

Other site module:
working2

When my modules have selected "Hide Legends" only the Desc text is displayed:
working3
And now all is working rightly again.
working4

Regards, Valc.

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 288c69e

I checked components, modules, plugins. Everything works as stated. Thank you.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37819.

@richard67
Copy link
Member

I know Github has a "tested with success or not" button, but each time a search it i can't found it easy... can you point me to the button, please?

@Valc That button is not on GitHub, it is in our issue tracker, e.g. for this PR on https://issues.joomla.org/tracker/joomla-cms/37819 . Use the blue “Test this” button at the top left corner, then select the right test result and the submit.

@ChristineWk ChristineWk mentioned this pull request May 18, 2022
Closed
@chmst
Copy link
Contributor

chmst commented May 18, 2022

I have tested this item ✅ successfully on b1cb875

Tested following the test instructions. Com_config, com_content and some other core components and an own plugin work as described. Thank you!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37819.

@bembelimen bembelimen merged commit dd25b96 into joomla:4.1-dev May 18, 2022
@bembelimen
Copy link
Contributor

Nice solution, thx

@cyrezdev cyrezdev mentioned this pull request May 21, 2022
Merged
@cyrezdev
Copy link
Contributor Author

UPDATE: see PR #37849 removing the inlinehelp attribute availability for form field xml element.

@Fedik Fedik mentioned this pull request Jun 24, 2022
Closed
@mckillo mckillo mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 4.1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@cyrezdev @Valc @Kostelano @richard67 @chmst @bembelimen @joomla-cms-bot